Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second defaultEntryPoint should be https, not http. #2948

Merged
merged 1 commit into from Feb 28, 2018
Merged

Second defaultEntryPoint should be https, not http. #2948

merged 1 commit into from Feb 28, 2018

Conversation

GerbenWelter
Copy link
Contributor

What does this PR do?

Fix the documentation for the defaultEntryPoints configuration. It erroneously uses "http" twice where it should use "http" and "https".

Motivation

Fix a typo in the configuration documentation.

More

  • Added/updated documentation

Additional Notes

None

ldez
ldez approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Feb 28, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 1.5 milestone Feb 28, 2018
@ldez ldez changed the base branch from master to v1.5 February 28, 2018 13:08
@traefiker traefiker merged commit 49a9e2a into traefik:v1.5 Feb 28, 2018
@GerbenWelter GerbenWelter deleted the typo branch February 28, 2018 13:25
@gozer gozer mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@GerbenWelter @juliens @mmatur @ldez @traefiker