Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete TLS-SNI-01 challenge from ACME #2971

Merged
merged 3 commits into from Mar 6, 2018
Merged

Delete TLS-SNI-01 challenge from ACME #2971

merged 3 commits into from Mar 6, 2018

Conversation

nmengin
Copy link
Contributor

@nmengin nmengin commented Mar 6, 2018 •
edited

What does this PR do?

This PR deletes the deprecated TLS-SNI-01 challenge.

Motivation

Clean code.
Show error if neither HTTP-01 nor DNS-01 challenge are specified.

More

  • Added/updated tests
  • Added/updated documentation

@nmengin nmengin added this to the 1.6 milestone Mar 6, 2018
mmatur
mmatur approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit c452982 into traefik:master Mar 6, 2018
@nmengin nmengin deleted the feature/delete-TLS-SNI-Challenge branch August 3, 2018 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/acme kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nmengin @juliens @mmatur @ldez @traefiker