Don't failed traefik start if register and subscribe failed on acme #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldcroes
reviewed
Mar 7, 2018
acme/acme.go
Outdated
| @@ -344,7 +344,9 @@ Let's Encrypt functionality will be limited until traefik is restarted.`, err) | |||
| log.Info("Register...") | |||
| reg, err := a.client.Register() | |||
| if err != nil { | |||
| return err | |||
| log.Errorf(`Failed to register user: %s | |||
| Let's Encrypt functionality will be limited until traefik is restarted.`, err) | |||
There was a problem hiding this comment.
Shouldn't Traefik be capitalized?
There was a problem hiding this comment.
Maybe: "You will need to restart Traefik to resume normal operation with Let's Encrypt" more accurate?
acme/acme.go
Outdated
| @@ -357,7 +359,9 @@ Let's Encrypt functionality will be limited until traefik is restarted.`, err) | |||
| // Let's Encrypt Subscriber Agreement renew ? | |||
| reg, err := a.client.QueryRegistration() | |||
| if err != nil { | |||
| return err | |||
| log.Errorf(`Failed to renew subscriber agreement: %s | |||
| Let's Encrypt functionality will be limited until traefik is restarted.`, err) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Log error when registering or AgreeToOS failed instead of fatal !
Motivation
Traefik still started when LE doesn't work
Fix #2976