Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Traefik TOML sample. #2996

Merged
merged 2 commits into from Mar 12, 2018
Merged

Enhance Traefik TOML sample. #2996

merged 2 commits into from Mar 12, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 11, 2018

What does this PR do?

Enhance Traefik TOML sample.

Motivation

Have a better starting sample.

@traefiker traefiker added this to the 1.5 milestone Mar 11, 2018
@ldez ldez requested review from a team as code owners March 11, 2018 09:52
nmengin
nmengin approved these changes Mar 12, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👍

mmatur
mmatur approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 📖

juliens
juliens approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit fc81d92 into traefik:v1.5 Mar 12, 2018
@ldez ldez deleted the refactor/traefik-sample branch March 13, 2018 14:17
@gozer gozer mentioned this pull request Apr 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker