Fix races #305
Merged
Fix races #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
fix-races
branch
3 times, most recently
from
819c0e2
to
85eff3f
Compare
| } | ||
|
|
||
| // Pool creates a pool of go routines | ||
| type Pool struct { |
There was a problem hiding this comment.
What about using sync.Pool here ? 👼
There was a problem hiding this comment.
Because I don't want these objects to be GC ;)
|
LGTM 🐯 |
ldez
added
status/3-needs-merge
and removed
status/2-needs-review
status/1-needs-design-review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some races in Traefik.
The Docker provider still needs to be fixed /cc @vdemeester