Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubernetes.md #3093

Merged
merged 1 commit into from Apr 3, 2018
Merged

Update kubernetes.md #3093

merged 1 commit into from Apr 3, 2018

Conversation

rdrgporto
Copy link
Contributor

@rdrgporto rdrgporto commented Mar 28, 2018 •
edited by ldez

What does this PR do?

In the section Add a TLS Certificate to the Ingress ( Link ) :

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: traefik-web-ui
  namespace: kube-system
  annotations:
    kubernetes.io/ingress.class: traefik
spec:
  rules:
  - host: traefik-ui.minikube
    http:
      paths:
      - backend:
          serviceName: traefik-web-ui
          servicePort: 80
  tls:
    secretName: traefik-ui-tls-cert

If we apply this manifest, we receive an error:

error: error validating "traefik-ingress.yaml": error validating data: expected type array, for field spec.tls, got map; if you choose to ignore these errors, turn validation off with --validate=false

In order to solve the issue, it is necessary to add a hyphen:

 - secretName: traefik-ui-tls-cert

More

  • Added/updated documentation

@rdrgporto rdrgporto requested a review from a team as a code owner March 28, 2018 10:04
@ldez ldez added this to the 1.6 milestone Mar 28, 2018
@ldez ldez removed the bot/no-merge label Mar 28, 2018
@mmatur mmatur changed the base branch from master to v1.6 March 28, 2018 12:28
ldez
ldez approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

timoreimann
timoreimann approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rdrgporto
Copy link
Contributor Author

You are welcome 👍

mmatur
mmatur approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdrgporto @traefiker
Update kubernetes.md
fa1b49b 
It is necessary to write a hyphen.
@traefiker traefiker merged commit 197a5fb into traefik:v1.6 Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rdrgporto @timoreimann @mmatur @ldez @traefiker