Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests on IPWhiteLister. #3106

Merged
merged 1 commit into from Apr 3, 2018
Merged

Add tests on IPWhiteLister. #3106

merged 1 commit into from Apr 3, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 30, 2018

What does this PR do?

Add tests on IPWhiteLister.

Motivation

Be safe.

More

  • Added/updated tests

@traefiker traefiker added this to the 1.6 milestone Mar 30, 2018
juliens
juliens approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 5921909 into traefik:v1.6 Apr 3, 2018
@ldez ldez deleted the feature/more-test-wl branch April 3, 2018 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@emilevauge emilevauge emilevauge approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @emilevauge @traefiker