Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes prefixed annotations support. #3110

Merged
merged 1 commit into from Apr 3, 2018
Merged

Fixes prefixed annotations support. #3110

merged 1 commit into from Apr 3, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 30, 2018 •
edited

What does this PR do?

Fixes prefixed annotations support for k8s.

Motivation

Fix a bug

More

  • Added/updated tests

@ldez ldez added this to the 1.6 milestone Mar 30, 2018
@ldez ldez requested a review from a team as a code owner March 30, 2018 20:58
timoreimann
timoreimann approved these changes Mar 30, 2018
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👏

@ldez ldez changed the title Prefixed annotations support. Fixes prefixed annotations support. Mar 30, 2018
juliens
juliens approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a179c3b into traefik:v1.6 Apr 3, 2018
@ldez ldez deleted the fix/k8s-annotations branch April 3, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@timoreimann timoreimann timoreimann approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @timoreimann @mmatur @traefiker