Generate wildcard certificate with SANs in ACME #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
force-pushed
the
fix/add-sans-in-wildcard
branch
from
f46bad1
to
d0b2d2c
Compare
SantoDE
approved these changes
Apr 11, 2018
nmengin
force-pushed
the
fix/add-sans-in-wildcard
branch
2 times, most recently
from
9ae0a86
to
ef997c3
Compare
traefiker
force-pushed
the
fix/add-sans-in-wildcard
branch
from
ef997c3
to
5144ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows generating ACME certificates for wildcard domains with SANs.
Motivation
Better support for ACME certificates.
Fixes #3092
More
Additional Notes
Some troubles have been detected with DNS providers during the tests.
Please refer to the documentation for more information and don't hesitate to give a feedback about the DNS provider you use.
Many thanks @SantoDE for your help!