Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing argument in log. #3188

Merged
merged 1 commit into from Apr 13, 2018
Merged

Add missing argument in log. #3188

merged 1 commit into from Apr 13, 2018

Conversation

chemidy
Copy link
Contributor

@chemidy chemidy commented Apr 13, 2018

  • add missing argument in log

dtomcej
dtomcej approved these changes Apr 13, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez changed the title Update server.go Add missing argument in log. Apr 13, 2018
@chemidy @ldez
Update server.go
faae5ab 
add missing argument in log
@ldez ldez changed the base branch from master to v1.6 April 13, 2018 17:20
@ldez ldez added this to the 1.6 milestone Apr 13, 2018
ldez
ldez approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 0373cd6 into traefik:v1.6 Apr 13, 2018
@chemidy chemidy deleted the chemidy-fix-log branch April 14, 2018 00:01
@ldez ldez added the area/logs label Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/logs kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chemidy @mmatur @ldez @dtomcej @traefiker