Create backup file during migration from ACME V1 to ACME V2 #3191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
kind/enhancement
juliens
requested changes
Apr 16, 2018
docs/configuration/acme.md
Outdated
|
|
||
| !!! note | ||
| When Træfik is launched in a container, do not forget to create a volume of the parent folder to get the backup file on the host. | ||
| Otherwise, the backup file will be delete when the conatiner will be stopeed and Træfik will not generate it again. |
There was a problem hiding this comment.
Otherwise, the backup file will be deleted when the container will be stopped and Træfik will not generate it again.
nmengin
force-pushed
the
feature/add-acme-file-backup
branch
from
06bfc2a
to
f8f50a6
Compare
nmengin
force-pushed
the
feature/add-acme-file-backup
branch
from
f8f50a6
to
b0ebe09
Compare
traefiker
force-pushed
the
feature/add-acme-file-backup
branch
from
ef73c08
to
a083f4b
Compare
This was referenced May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creating a backup file which contains the ACME V1 data during migration to ACME V2 file format.
Motivation
Allow easier rollback to ACME V1.
More
Additional Notes
Fix #3162 by checking ACME certificate content before set and get actions.