Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward auth: copy response headers when auth failed. #3207

Merged
merged 1 commit into from Apr 23, 2018
Merged

Forward auth: copy response headers when auth failed. #3207

merged 1 commit into from Apr 23, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 19, 2018

What does this PR do?

Forward auth: copy response headers when auth failed.

Motivation

Fix a bug.

More

  • Added/updated tests

@traefiker traefiker added this to the 1.6 milestone Apr 19, 2018
nmengin
nmengin approved these changes Apr 20, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/auth-forward-resp-headers branch from d20388e to f161464 Compare April 22, 2018 00:54
juliens
juliens approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/auth-forward-resp-headers branch from f161464 to e741974 Compare April 23, 2018 09:36
@traefiker traefiker merged commit 2975acd into traefik:v1.6 Apr 23, 2018
@ldez ldez deleted the fix/auth-forward-resp-headers branch April 23, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/authentication area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker