Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error pages redirect and headers. #3217

Merged
merged 2 commits into from Apr 23, 2018
Merged

Fix error pages redirect and headers. #3217

merged 2 commits into from Apr 23, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Apr 20, 2018 •
edited

What does this PR do?

  • fix: error pages query redirect.
  • fix: error pages headers

Motivation

Fixes #2939

More

  • Added/updated tests

@ldez ldez added this to the 1.6 milestone Apr 20, 2018
@ldez ldez changed the title fix: error pages redirect. fix: Error pages redirect and headers. Apr 21, 2018
juliens
juliens approved these changes Apr 22, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mmatur
mmatur approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur changed the title fix: Error pages redirect and headers. Fix error pages redirect and headers. Apr 23, 2018
@traefiker traefiker merged commit 76dcbe3 into traefik:v1.6 Apr 23, 2018
@traefiker traefiker mentioned this pull request Apr 23, 2018
Closed
@ldez ldez deleted the fix/error-pages-redirect branch April 23, 2018 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker