Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to documentation #3221

Merged
merged 4 commits into from Apr 23, 2018
Merged

Minor improvements to documentation #3221

merged 4 commits into from Apr 23, 2018

Conversation

colincoller
Copy link
Contributor

What does this PR do?

Makes minor improvements to the documentation:

  • adds a missing space
  • fixes a broken link
  • fixes some grammar and punctuation
  • changes the order/indenting of topics under Basics > Backends to make it a bit easier to get started

Motivation

Just things I noticed while getting started with Traefik

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez added this to the 1.6 milestone Apr 23, 2018
@ldez ldez changed the base branch from master to v1.6 April 23, 2018 08:58
@ldez ldez removed the bot/no-merge label Apr 23, 2018
ldez
ldez approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Apr 23, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 📖

juliens
juliens approved these changes Apr 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 667a0c4 into traefik:v1.6 Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/documentation size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@colincoller @juliens @ldez @nmengin @traefiker