Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override health check scheme #3315

Merged
merged 7 commits into from May 14, 2018
Merged

Override health check scheme #3315

merged 7 commits into from May 14, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented May 12, 2018 •
edited

What does this PR do?

Be able to override health check scheme.

Motivation

Fixes #2683

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 1.7 milestone May 12, 2018
@ldez ldez requested review from a team as code owners May 12, 2018 12:57
@ldez ldez changed the title Availability to override health check scheme Override health check scheme May 12, 2018
mmatur
mmatur approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes May 14, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes May 14, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the feature/healthcheck-proto branch from c6303f3 to 186cb57 Compare May 14, 2018 09:52
@traefiker traefiker merged commit df11e67 into traefik:master May 14, 2018
@ldez ldez deleted the feature/healthcheck-proto branch May 14, 2018 10:08
@ldez ldez mentioned this pull request May 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/healthcheck area/provider/consul area/provider/consulcatalog area/provider/docker area/provider/ecs area/provider/kv area/provider/marathon area/provider/mesos area/provider/rancher kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker