Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segment backend name #3317

Merged
merged 3 commits into from May 14, 2018
Merged

Conversation

ldez
Copy link
Member

@ldez ldez commented May 12, 2018

What does this PR do?

Fix segment backend name.

Before this PR:
The label traefik.backend was partially ignored.
The traefik.<segment_name>.frontend.backend label was used to name segment backend, this suggested that it was possible to set a backend manually for a frontend but it's not.

With this PR:
The label traefik.backend is fully used.
The traefik.<segment_name>.frontend.backend label is removed for the benefit of traefik.<segment_name>.backend

Motivation

Fix a bug.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants