Add option to select algorithm to generate ACME certificates #3319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
added
kind/enhancement
nmengin
requested changes
May 15, 2018
provider/acme/account.go
Outdated
| keyType = acme.RSA4096 | ||
| case "RSA8192": | ||
| keyType = acme.RSA8192 | ||
| } |
There was a problem hiding this comment.
WDYT to you manage the default case?
Maybe just add a warning/error message to indicate that the default algorithm will be used because the given one is not managed.
acme/account.go
Outdated
| @@ -103,6 +107,25 @@ func (a *Account) GetPrivateKey() crypto.PrivateKey { | |||
| return nil | |||
| } | |||
|
|
|||
| func getKeyType(value string) acme.KeyType { | |||
There was a problem hiding this comment.
This function seems to be a duplicate of provider/acme/account.go.
Maybe can you make the function in provider/acme/account.go public and delete this one?
This kind of management is already used in ACME.
docs/configuration/acme.md
Outdated
| # Optional | ||
| # Default: "RSA4096" | ||
| # | ||
| # Available value : "EC256", "EC384", "RSA2048", "RSA4096", "RSA8192" |
| @@ -9,15 +9,15 @@ readonly doc_file=$basedir"/docker-compose.yml" | |||
| down_environment() { | |||
| echo "STOP Docker environment" | |||
| ! docker-compose -f $doc_file down -v &>/dev/null && \ | |||
| echo "[ERROR] Impossible to stop the Docker environment" && exit 11 | |||
| echo "[ERROR] Unable to stop the Docker environment" && exit 11 | |||
nmengin
changed the title
mmatur
force-pushed
the
feature/acme-ecdsa
branch
from
1491bca
to
7c985af
Compare
mmatur
force-pushed
the
feature/acme-ecdsa
branch
from
7c985af
to
f83954c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allow user to choose which key type to use to generate private key
Motivation
Fixes #2940
More