Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route rules overlaps in UI #3333

Merged
merged 1 commit into from May 16, 2018
Merged

Route rules overlaps in UI #3333

merged 1 commit into from May 16, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented May 16, 2018

What does this PR do?

Route rules overlaps in UI.

Motivation

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m3co-code
Copy link
Contributor

You are sure that the app.sass should be deleted?

@ldez
Copy link
Member Author

ldez commented May 16, 2018

Yes because it's unused, we use the app.sass at the root of the project.

Copy link
Contributor

@m3co-code m3co-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit a0872c9 into traefik:v1.6 May 16, 2018
@ldez ldez deleted the fix/rule-overlaps branch May 16, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants