Upgrade GRPC dependencies #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3co-code
approved these changes
May 17, 2018
There was a problem hiding this comment.
@gottwald is a member of our Team together with @timoreimann and we were working closely together. Therefore, naturally, I can give my LGTM already!
ldez
added
kind/enhancement
Newer protobuf libs check for valid utf-8 chars in a stream of strings. Random bytes casted to a string will not always yield a valid utf-8 character. This change enforces a valid set of characters used as source for the random string in the integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates specific dependencies to the most recent stable versions and fixes one testing bug that was made visible by the upgrade.
Motivation
We're working internally on integrating stackdriver into traefik (PR will follow). We need newer grpc and protobuf libraries to make it work. While upgrading those we've discovered outdated libs, which some even were in a pre-stable version.
More
Additional Notes
Only one test broke with the update which is fixed in 329efa5.
The old protobuf library did not validate string types. The proto3 specifications state that the string type must be encoded as valid UTF-8 and validation was introduced in newer versions of the protobuf library.
This broke this one test in traefik that created a string by creating a random set of bytes and casting it into a string, which yields non-valid UTF-8 characters.