Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command for basic auth with Docker Compose #3346

Merged
merged 2 commits into from May 18, 2018
Merged

Add command for basic auth with Docker Compose #3346

merged 2 commits into from May 18, 2018

Conversation

DeamonMV
Copy link
Contributor

@DeamonMV DeamonMV commented May 18, 2018 •
edited by ldez

What does this PR do?

Added footnote for parameter traefik.frontend.auth.basic which is describe how to use it for example of make secure dashboard of Traefik

Motivation

More

  • Added/updated tests
  • Added/updated documentation

@DeamonMV DeamonMV requested a review from a team as a code owner May 18, 2018 08:36
@ldez ldez changed the base branch from master to v1.6 May 18, 2018 08:55
@ldez ldez added this to the 1.6 milestone May 18, 2018
ldez
ldez approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the title Updated docker.md Add command for basic auth with Docker Compose May 18, 2018
mmatur
mmatur approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes May 18, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DeamonMV and others added 2 commits May 18, 2018 15:14
@DeamonMV @traefiker
Updated docker.md
70676e3 
Added footnote for parameter traefik.frontend.auth.basic which is describe how to use it for example of make secure dashboard of traefik
@ldez @traefiker
review: simplify.
228e1b0
@traefiker traefiker merged commit c376083 into traefik:v1.6 May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DeamonMV @juliens @mmatur @ldez @traefiker