Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all 2xx HTTP status code for health check. #3362

Merged
merged 1 commit into from May 22, 2018
Merged

Support all 2xx HTTP status code for health check. #3362

merged 1 commit into from May 22, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented May 21, 2018

What does this PR do?

Support all 2xx HTTP status code for health check.

Motivation

Fixes #3081

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 1.7 milestone May 21, 2018
juliens
juliens approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes May 22, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 22, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit e2bac47 into traefik:master May 22, 2018
@ldez ldez deleted the feat/healthcheck-2xx branch May 22, 2018 07:53
@SniperCZE SniperCZE mentioned this pull request May 22, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/healthcheck kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker