Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement h2c with backend #3371

Merged
merged 3 commits into from May 24, 2018
Merged

Implement h2c with backend #3371

merged 3 commits into from May 24, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented May 23, 2018

What does this PR do?

Add h2c support with backend.

Motivation

Simplify the use of http2 with backend.
Fixes #2139

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

This PR add a new "protocol" in the backend server.
h2c://{backend}

@juliens juliens added kind/enhancement a new or improved feature. status/2-needs-review labels May 23, 2018
@juliens juliens force-pushed the h2c-client branch 3 times, most recently from 2926b30 to 142dd63 Compare May 23, 2018 09:43
@ldez ldez added this to the 1.7 milestone May 23, 2018
@ldez ldez removed the bot/no-merge label May 23, 2018
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 👏 👏

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -76,40 +60,25 @@ rootCAs = [ "./backend.cert" ]
```

!!! warning
With some backends, the server URLs use the IP, so you may need to configure `insecureSkipVerify` instead of the `rootCAS` to activate HTTPS without hostname verification.
For provider with label, you will have to specify the `frontend.protocol=h2c`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontend.protocol is a new label? It should be traefik.protocol instead?

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants