Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated assets file are only mandatory in main #3386

Merged
merged 1 commit into from May 25, 2018
Merged

Generated assets file are only mandatory in main #3386

merged 1 commit into from May 25, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented May 25, 2018

What does this PR do?

This PR changes where we instantiate the assets for dashboard

Motivation

More flexible code.

@juliens juliens added kind/enhancement a new or improved feature. status/2-needs-review labels May 25, 2018
ldez
ldez approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes May 25, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the 1.7 milestone May 25, 2018
nmengin
nmengin approved these changes May 25, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bfdd199 into traefik:master May 25, 2018
@juliens juliens deleted the traefik-vendoring branch July 9, 2018 13:31
@ldez ldez mentioned this pull request Sep 29, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @mmatur @ldez @nmengin @traefiker