Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extreme Makeover: server refactoring #3461

Merged
merged 20 commits into from Jun 11, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Jun 8, 2018

What does this PR do?

Extreme Makeover: server refactoring.

Motivation

Be more maintainable.

More

  • Added/updated tests

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
LGTM
:shipit:

@dtomcej
Copy link
Contributor

dtomcej commented Jun 8, 2018

You are going deep on this one!

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome refactoring 👏
LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

@traefiker traefiker merged commit eac20d6 into traefik:master Jun 11, 2018
@ldez ldez deleted the refactor/extreme-makeover branch June 11, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants