-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substitute hardcoded "<namespace>/<name>" with k8s ListerGetter #3470
Merged
traefiker
merged 5 commits into
traefik:master
from
yue9944882:chore-listergetter-funcs-to-get-resource
Jul 4, 2018
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3859fd6
cleanup hardcoded "<namespace>/<name>" and use listergetter
yue9944882 77c60f4
translate not found error
yue9944882 1b6ee3f
review: update error msg & add unit test
yue9944882 aaa37c5
review: minor changes
yue9944882 37b9698
review: order fields.
ldez File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
package kubernetes | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
kubeerror "k8s.io/apimachinery/pkg/api/errors" | ||
"k8s.io/apimachinery/pkg/runtime/schema" | ||
) | ||
|
||
func TestTranslateNotFoundError(t *testing.T) { | ||
testCases := []struct { | ||
desc string | ||
err error | ||
expectedExists bool | ||
expectedError error | ||
}{ | ||
{ | ||
desc: "kubernetes not found error", | ||
err: kubeerror.NewNotFound(schema.GroupResource{}, "foo"), | ||
expectedExists: false, | ||
expectedError: nil, | ||
}, | ||
{ | ||
desc: "nil error", | ||
err: nil, | ||
expectedExists: true, | ||
expectedError: nil, | ||
}, | ||
{ | ||
desc: "not a kubernetes not found error", | ||
err: fmt.Errorf("bar error"), | ||
expectedExists: false, | ||
expectedError: fmt.Errorf("bar error"), | ||
}, | ||
} | ||
|
||
for _, testCase := range testCases { | ||
test := testCase | ||
t.Run(test.desc, func(t *testing.T) { | ||
t.Parallel() | ||
|
||
exists, err := translateNotFoundError(test.err) | ||
assert.Equal(t, test.expectedExists, exists) | ||
assert.Equal(t, test.expectedError, err) | ||
}) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about just doing
here and elsewhere too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timoreimann I'm afraid my IDE is not allowing me to do so. Is this syntax supported by golang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, my bad.