Add a default value for the docker.network configuration #3471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
reviewed
Jun 11, 2018
| @@ -71,6 +71,12 @@ usebindportip = true | |||
| # | |||
| swarmMode = false | |||
|
|
|||
| # Define a default docker network to use for connections to all containers. | |||
There was a problem hiding this comment.
Maybe we should add the fact that it's possible to override this with the label traefik.docker.network
| @@ -45,6 +45,7 @@ type Provider struct { | |||
| ExposedByDefault bool `description:"Expose containers by default" export:"true"` | |||
| UseBindPortIP bool `description:"Use the ip address from the bound port, rather than from the inner network" export:"true"` | |||
| SwarmMode bool `description:"Use Docker on Swarm Mode" export:"true"` | |||
| Network string `description:"Default Docker network used" export:"true"` | |||
There was a problem hiding this comment.
Shouldn't we call it DefaultNetwork instead?
There was a problem hiding this comment.
To be homogeneous with domain, we need to keep Network.
ldez
changed the title
ldez
requested changes
Jun 11, 2018
provider/docker/docker.go
Outdated
| @@ -45,6 +45,7 @@ type Provider struct { | |||
| ExposedByDefault bool `description:"Expose containers by default" export:"true"` | |||
| UseBindPortIP bool `description:"Use the ip address from the bound port, rather than from the inner network" export:"true"` | |||
| SwarmMode bool `description:"Use Docker on Swarm Mode" export:"true"` | |||
| DefaultNetwork string `description:"Default Docker network used" export:"true"` | |||
There was a problem hiding this comment.
To be homogeneous with domain, we need to keep Network.
There was a problem hiding this comment.
Are you both ok with Network ? :)
mmatur
requested changes
Jun 11, 2018
jbdoumenjou
force-pushed
the
feature/default-docker-network
branch
from
4d1ac5f
to
d209e36
Compare
ldez
requested changes
Jun 11, 2018
There was a problem hiding this comment.
You need to update https://github.com/containous/traefik/blob/master/docs/configuration/backends/docker.md#on-containers
traefik.docker.network
jbdoumenjou
force-pushed
the
feature/default-docker-network
branch
from
fa9cb4b
to
d434cb9
Compare
This reverts commit 1a0bfe789cf64277700e1c831fa432282de9440c.
jbdoumenjou
force-pushed
the
feature/default-docker-network
branch
from
d434cb9
to
50f47ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a default value for the traefik.docker.network configuration.
Motivation
Implement the #3449
More
Additional Notes
I can't test it due to the limitation of the docker test library (we can't manipulate the networks).