Allow Modifier type to be changed via annotation in a Kubernetes Ingress #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
status/1-needs-design-review
and removed
status/0-needs-triage
status/2-needs-review
labels
|
Hello @alexquintero, Thanks for your contribution! Unfortunately, rewrite-target is not an annotation that can have its behavior switched, as it will cause other issues with compatability. However, the need for matchers is indeed important, and I have created a PR (#3481) that will enable all the matchers. Once that PR is merged, we will close this one. Please take a look, and give feedback on that PR if you wish. |
|
Closed in favor of #3481 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows you to specify ReplacePathRegex rewrites using a Kubernetes Ingress backend. It works by creating an annotation (
traefik.ingress.kubernetes.io/modifier-type: ReplacePathRegex) that overrides the default of ‘ReplacePath’.Motivation
There was no way to specify these kinds of rewrite rules using Kubernetes Ingress backends. We needed this to preserve some compatibility between old clients and new APIs hosted in Kubernetes.
More
Potentially solves Issue 2985.