ACME TLS ALPN #3553
Merged
ACME TLS ALPN #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
mmatur
requested changes
Jul 2, 2018
integration/acme_test.go
Outdated
| pebbleTransport, err := setupPebbleRootCA() | ||
| if err != nil { | ||
| c.Fatal(err) | ||
| } | ||
|
|
||
| // wait for boulder |
There was a problem hiding this comment.
Could you replace by Wait for peddle
provider/acme/challenge_tls.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &certificate, nil |
ldez
force-pushed
the
feature/acme-tls-alpn
branch
2 times, most recently
from
ed39ff1
to
62481e9
Compare
ldez
force-pushed
the
feature/acme-tls-alpn
branch
from
62481e9
to
a1642f6
Compare
mmatur
approved these changes
Jul 3, 2018
traefiker
force-pushed
the
feature/acme-tls-alpn
branch
from
a1642f6
to
c675492
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the ACME challenge TLS-ALPN-01
Motivation
Add a new challenge for ACME.
More
Additional Notes
https://community.letsencrypt.org/t/tls-alpn-validation-method/63814