Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes #3554

Merged
merged 1 commit into from Jul 3, 2018
Merged

Minor changes #3554

merged 1 commit into from Jul 3, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 2, 2018

What does this PR do?

  • Error strings should not be capitalized
  • Add spaces in comment

Motivation

In order to be homogeneous.

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Jul 2, 2018
@ldez ldez added this to the 1.7 milestone Jul 2, 2018
@ldez ldez requested review from a team as code owners July 2, 2018 12:04
mmatur
mmatur approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 17ad515 into traefik:master Jul 3, 2018
@ldez ldez deleted the refactor/cleaning branch July 3, 2018 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature. size/M
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker