Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyFile first/last line comment in kv-config.md #3558

Merged
merged 1 commit into from Jul 4, 2018
Merged

Update keyFile first/last line comment in kv-config.md #3558

merged 1 commit into from Jul 4, 2018

Conversation

madnight
Copy link
Contributor

@madnight madnight commented Jul 4, 2018 •
edited

What does this PR do?

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez added this to the 1.6 milestone Jul 4, 2018
@mmatur mmatur changed the base branch from master to v1.6 July 4, 2018 12:10
ldez
ldez approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b183658 into traefik:v1.6 Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/kv size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@madnight @juliens @mmatur @ldez @traefiker