Call functions to enable block/mutex pprof profiles. #3564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
kind/enhancement
timoreimann
force-pushed
the
call-runtime-functions-enabling-block-mutex-pprof-profiles
branch
from
bf97951
to
78df9ff
Compare
|
Kudos to @marco-jantke for clarifying the need. |
According to the documentation[1], specific functions must be called for block and mutex pprof profiles to be generated actually. This change does so in case the debug mode is enabled. [1]https://golang.org/pkg/net/http/pprof/
traefiker
force-pushed
the
call-runtime-functions-enabling-block-mutex-pprof-profiles
branch
from
78df9ff
to
084b69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Call
runtime.SetBlockProfileRateandruntime.SetMutexProfileFractionwhen debug mode is enabled.Motivation
According to the documentation, these functions must be called for block and mutex pprof profiles to be generated actually.