Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Namecheap status #3604

Merged
merged 1 commit into from Jul 23, 2018
Merged

Update Namecheap status #3604

merged 1 commit into from Jul 23, 2018

Conversation

stoinov
Copy link
Contributor

@stoinov stoinov commented Jul 11, 2018

What does this PR do?

I updated the status of Namecheap for the DNS challenge

Motivation

I tested and was able to use the DNS challenge for a wildcard certificates with Namecheap

More

  • Added/updated documentation

@SantoDE
Copy link
Collaborator

SantoDE commented Jul 23, 2018

Just a heads up to @stoinov ,

I finally have namecheap API access. I gonna test either tonight or tommorow :)

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm: works.

Thanks for testing first! :)

LGTM 🙌

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej changed the base branch from master to v1.7 July 23, 2018 19:53
@dtomcej
Copy link
Contributor

dtomcej commented Jul 23, 2018

Changing to 1.7 base

@dtomcej dtomcej added bot/light-review decreases the number of required LGTM from 3 to 1. and removed bot/need-human-merge labels Jul 23, 2018
@dtomcej dtomcej removed the bot/light-review decreases the number of required LGTM from 3 to 1. label Jul 23, 2018
@ldez ldez added this to the 1.7 milestone Jul 23, 2018
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bafb583 into traefik:v1.7 Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants