Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated templates #3649

Merged
merged 2 commits into from Jul 23, 2018
Merged

Removes deprecated templates #3649

merged 2 commits into from Jul 23, 2018

Conversation

geraldcroes
Copy link
Contributor

@geraldcroes geraldcroes commented Jul 20, 2018 •
edited by ldez

What does this PR do?

It removes the deprecated templates v1 support.

More

  • Added/updated tests

@geraldcroes
Remove Configuration V1
a44b265 
- consulcatalog
- docker
- marathon
- mesos
- ecs
- rancher
@geraldcroes
go generate
26e1ef5
@geraldcroes geraldcroes requested review from a team as code owners July 20, 2018 12:42
@ldez ldez changed the title Removes Configuration V1 Removes template V1 Jul 20, 2018
@ldez ldez changed the title Removes template V1 Removes templates Jul 20, 2018
@ldez ldez removed request for a team July 20, 2018 12:51
@ldez ldez added this to the 1.8 milestone Jul 20, 2018
SantoDE
SantoDE approved these changes Jul 22, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell of work. LGTM 👼

juliens
juliens approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit f611ef0 into traefik:master Jul 23, 2018
@ldez ldez deleted the remove-configuration-v1 branch July 23, 2018 10:31
@ldez ldez changed the title Removes templates Removes deprecated templates Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@geraldcroes @juliens @SantoDE @mmatur @ldez @traefiker