Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TLS in API #3665

Merged
merged 2 commits into from Jul 26, 2018
Merged

Remove TLS in API #3665

merged 2 commits into from Jul 26, 2018

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Jul 24, 2018 •
edited

What does this PR do?

This PR removes TLS in the API

Motivation

Fixes #3651, #3669

@mmatur mmatur added this to the 1.7 milestone Jul 24, 2018
@mmatur mmatur force-pushed the fix/certs-acme-provider-api branch from e946c06 to 2adaa11 Compare July 24, 2018 11:31
juliens
juliens approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jul 24, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

@mmatur mmatur force-pushed the fix/certs-acme-provider-api branch from 2adaa11 to ff1f424 Compare July 24, 2018 12:24
@mmatur mmatur force-pushed the fix/certs-acme-provider-api branch 7 times, most recently from 752ed85 to 8cc491b Compare July 26, 2018 09:18
@mmatur mmatur requested review from a team as code owners July 26, 2018 09:18
@mmatur mmatur force-pushed the fix/certs-acme-provider-api branch from 8cc491b to 90b4751 Compare July 26, 2018 09:19
@mmatur mmatur removed request for a team July 26, 2018 09:19
@mmatur mmatur removed request for a team July 26, 2018 09:19
@mmatur mmatur force-pushed the fix/certs-acme-provider-api branch from 90b4751 to 99816bb Compare July 26, 2018 10:18
@traefiker traefiker merged commit 73b4df4 into traefik:v1.7 Jul 26, 2018
This was referenced Jul 26, 2018
Closed
Closed
@mmatur mmatur deleted the fix/certs-acme-provider-api branch July 26, 2018 10:42
@gliwka
Copy link

gliwka commented Aug 19, 2018

Is there a security advisory / CVE for this? Exposing the private key like this seems to warrant more than just a pull request.

@juliens juliens mentioned this pull request Aug 20, 2018
Merged
@dduportal dduportal mentioned this pull request Aug 20, 2018
Merged
1 task
@emilevauge
Copy link
Member

emilevauge commented Aug 21, 2018 •
edited

@gliwka

@denji denji mentioned this pull request Aug 23, 2018
Closed
@mmatur mmatur mentioned this pull request Nov 23, 2018
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@SantoDE SantoDE SantoDE approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/api kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mmatur @gliwka @emilevauge @juliens @SantoDE @nmengin @traefiker