Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated elements #3666

Merged
merged 14 commits into from Jul 31, 2018
Merged

Remove deprecated elements #3666

merged 14 commits into from Jul 31, 2018

Conversation

jbdoumenjou
Copy link
Member

@jbdoumenjou jbdoumenjou commented Jul 24, 2018 •
edited

What does this PR do?

Remove some deprecated stuff:

  • ClientCAFiles
  • Consul Catalog methods
  • ecs cluster
  • Flaeg.Duration
  • GraceTimeOut
  • Marathon configuration methods
  • PassHostHeader
  • Sticky
  • TraefikLogsFile/AccessLogFile
  • try.Sleep
  • Web option
  • Weight 0

Motivation

To be clean :)

More

  • Added/updated tests
  • Added/updated documentation

@jbdoumenjou jbdoumenjou added this to the next milestone Jul 24, 2018
@jbdoumenjou jbdoumenjou requested review from a team as code owners July 24, 2018 13:08
@ldez ldez removed request for a team July 24, 2018 22:20
mmatur
mmatur approved these changes Jul 27, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👏 😪

dtomcej
dtomcej approved these changes Jul 31, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou and others added 14 commits July 31, 2018 16:58
@jbdoumenjou @juliens @traefiker
Clean the deprecated passHostHeader for the kv provider
688fea0 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
replace flaeg.Duration by parse.Duration
762e924 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove deprecated for the weight 0
74e15ad 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove deprecated Web option
1d3c7ec 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove more Deprecated
7a2ef5e 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove some deprecated from the documentation
0ac734b 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove deprecated template versions
5e1cdd7 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove the Deprecated sticky
609e477 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Update generated template file
57a75fc 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove deprecated method on consul catalog
588e76f 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove deprecated marathon configuration methods
1add233 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove deprecated sticky in the documentation
10191ec 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Remove some deprecated usage of try.Sleep
a3baf73 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@jbdoumenjou @juliens @traefiker
Fix for review
52d79e2 
Co-authored-by: Julien Salleyron <julien.salleyron@gmail.com>
@traefiker traefiker merged commit 8627256 into traefik:master Jul 31, 2018
@jbdoumenjou jbdoumenjou deleted the feature/clean-deprecated branch November 21, 2018 08:44
@ldez ldez changed the title Remove Deprecated Step 1 Remove deprecated code Mar 15, 2019
@ldez ldez changed the title Remove deprecated code Remove deprecated elements Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jbdoumenjou @juliens @mmatur @nmengin @dtomcej @ldez @traefiker