Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H2C: Remove buggy line in init to make verbose switch working #3701

Merged
merged 1 commit into from Jul 31, 2018
Merged

H2C: Remove buggy line in init to make verbose switch working #3701

merged 1 commit into from Jul 31, 2018

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Jul 31, 2018

Signed-off-by: Damien DUPORTAL damien.duportal@gmail.com

What does this PR do?

The "copy-and-pasted" line had been deleted: this deleted line was overwriting the user-provided verbose mode's switch, forcing the verbose mode to true.

Motivation

Fixes #3662

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Should be a quick one.

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is absolutely crazy
LGTM

Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
@traefiker traefiker merged commit ed0c7d9 into traefik:v1.7 Jul 31, 2018
@dduportal dduportal deleted the GH-3662-h2c-init-bug branch August 1, 2018 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants