Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for npm progress=false #3702

Merged
merged 1 commit into from Aug 1, 2018

Conversation

vdemeester
Copy link
Contributor

@vdemeester vdemeester commented Jul 31, 2018

What does this PR do?

Removes a useless RUN in the webui Dockerfile.
yarn is used instead of npm, this line is outdated 馃槤

Motivation

Clean Dockerfiles

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Signed-off-by: Vincent Demeester vincent@sbr.pm

@traefiker

This comment has been minimized.

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the next milestone Aug 1, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yarn is used instead of npm, this line is outdated

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@traefiker traefiker merged commit d727761 into traefik:master Aug 1, 2018
@vdemeester vdemeester deleted the micro-webui-dockerfile-fix branch August 1, 2018 09:18
@ldez ldez added the kind/enhancement a new or improved feature. label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants