Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small code enhancements #3712

Merged
merged 3 commits into from Aug 6, 2018
Merged

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Aug 2, 2018

What does this PR do?

  • Simplify some code
  • Check some errors

Motivation

Clean, Readable code. first step to be able to have a linter running on Træfik

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @mmatur 🍻

LGTM

Copy link
Contributor

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9cd47dd into traefik:master Aug 6, 2018
@mmatur mmatur deleted the feature/improve-code branch January 10, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants