Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated elements #3715

Merged
merged 4 commits into from Aug 6, 2018
Merged

Remove deprecated elements #3715

merged 4 commits into from Aug 6, 2018

Conversation

geraldcroes
Copy link
Contributor

@geraldcroes geraldcroes commented Aug 2, 2018 •
edited by ldez

What does this PR do?

Removes the following deprecated elements:

  • basic-auth
  • duplicate information from the logs
  • Etcd-v2 support
  • k8s old annotations

Motivation

Remove deprecated

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

See #2212

@geraldcroes geraldcroes added this to the next milestone Aug 2, 2018
ldez
ldez approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Aug 2, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@juliens juliens self-requested a review August 3, 2018 06:55
@geraldcroes geraldcroes requested a review from a team as a code owner August 3, 2018 10:37
juliens
juliens approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez removed the request for review from a team August 3, 2018 11:16
@ldez ldez force-pushed the remove-deprecated branch 2 times, most recently from 187c4fc to 8113134 Compare August 3, 2018 11:35
@ldez ldez force-pushed the remove-deprecated branch 4 times, most recently from 086f872 to 79c76af Compare August 3, 2018 15:33
@traefiker traefiker merged commit 015cd7a into traefik:master Aug 6, 2018
@ldez ldez deleted the remove-deprecated branch August 6, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/authentication area/logs area/provider/etcd kind/enhancement a new or improved feature. size/L
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@geraldcroes @juliens @ldez @dtomcej @traefiker