Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in auth labels. #3730

Merged
merged 1 commit into from Aug 8, 2018
Merged

Typo in auth labels. #3730

merged 1 commit into from Aug 8, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Aug 5, 2018

What does this PR do?

Replaced usersfile by usersFile in labels documentation.

Motivation

Have a good documentation.

Fixes #3673

More

  • Added/updated documentation

@ldez ldez requested review from a team as code owners August 5, 2018 10:12
@traefiker traefiker added this to the 1.7 milestone Aug 5, 2018
@ldez ldez removed request for a team August 5, 2018 10:12
@ldez ldez changed the title fix: typo in auth labels. Typo in auth labels. Aug 5, 2018
@dduportal
Copy link
Contributor

LGTM

nmengin
nmengin approved these changes Aug 5, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📖

juliens
juliens approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Aug 7, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit 2d449f6 into traefik:v1.7 Aug 8, 2018
@traefiker traefiker mentioned this pull request Aug 8, 2018
Closed
@ldez ldez deleted the fix/auth-labels branch August 8, 2018 00:52
@pitan pitan mentioned this pull request Aug 20, 2019
Merged
2 tasks
@nilskuhn

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@nmengin nmengin nmengin approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ldez @dduportal @nilskuhn @juliens @nmengin @dtomcej @traefiker