Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't merge kubernetes ingresses when priority is set #3743

Merged
merged 1 commit into from Aug 14, 2018
Merged

Don't merge kubernetes ingresses when priority is set #3743

merged 1 commit into from Aug 14, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Aug 7, 2018

What does this PR do?

Ensures separate frontends are created when ingress priorities are set

Motivation

Fixes #3710

More

  • Added/updated tests
  • Added/updated documentation - None needed, intended behavior

Additional Notes

  1. The issue reported in the ticket [Kubernetes] Priority and same host ingresses not working #3710 may not be solved by this ticket, but it does resolve some of the unintended behavior
  2. This change still allows duplicate host/paths to be skipped across namespaces.
  3. Changing the basename to {{namespace}}/{{ingress.name}}-{{host}}{{path}} although unique, would be too breaking for a minor release.

@dtomcej dtomcej requested a review from a team as a code owner August 7, 2018 20:49
@traefiker traefiker added this to the 1.7 milestone Aug 7, 2018
mmatur
mmatur approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

juliens
juliens approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit bd3c8c3 into traefik:v1.7 Aug 14, 2018
@traefiker traefiker mentioned this pull request Aug 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtomcej @juliens @mmatur @nmengin @ldez @traefiker