Added Dashboard table item for Rate Limits #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldcroes
added
status/2-needs-review
kind/bug/fix
|
@codecyclist could you rebase on v1.7 and change the base branch of the PR to v1.7 (edit button on the top of the PR) |
i78
force-pushed
the
feature/dashboard_add_rate_limit_table
branch
from
7d5e47c
to
5c51d05
Compare
i78
force-pushed
the
feature/dashboard_add_rate_limit_table
branch
from
5c51d05
to
7d5e47c
Compare
i78
force-pushed
the
feature/dashboard_add_rate_limit_table
branch
from
7d5e47c
to
b990eec
Compare
|
@ldez done. :) |
SantoDE
approved these changes
Sep 18, 2018
nmengin
changed the title
…dd_rate_limit_table
…dd_rate_limit_table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a "Rate limiting" section to the frontend items on the traefik dashboard.
Motivation
The primary aim is to visualize the presence (and absence) of rate limiting rules in the dashboard in order to provide a quick overview over the rate limit rules traefik gathered from the configuration sources.
More
Additional Notes
I added (Angular) tests for the filter pipe, but the existing appear to need rework. I will issue a separate PR for that.