Do not copy hop-by-hop headers to forward auth request #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @emilevauge thanks for your message and for merging the other PR. Unfortunately this is another fix :). #3900 removed the hop-by-hop headers from the response of the auth backend. Whereas this new PR prevents adding hop-by-hop headers to the request that is sent to the auth backend. So this PR makes sure no hop-by-hop headers get send to the auth backend, the other one (#3900) makes sure no hop-by-hop headers received from the auth backend get send back to the receiver. |
|
@stffabi Sorry, I read too quickly ;) |
|
@emilevauge thanks a lot for merging the PR. Awesome how fast all of you reply and how much attention all of you pay to community contributions. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hop-By-Hop headers aren't passed over to the auth backend anymore.
Motivation
Copying over Hop-By-Hop header might result in a wrong behaviour, e.g. if a websocket is requested, the auth backend request fails and a HTTP 500 error code is returned. Therefore websocket don't work anymore when a forward auth backend is enabled.
Fixes #3039
More