Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly initialize kv store if storage key missing #3958

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Correctly initialize kv store if storage key missing #3958

merged 1 commit into from
Oct 1, 2018

Commits on Oct 1, 2018

  1. Correctly initialize kv store if storage key missing 

    It looks like this commit might have introduced a bug
(I'm new to the code, so I might be wrong):
e4bb506#diff-89592b0a96bd24ccd41291548f9a07a3

On line 88, keyExists will return an error ErrKeyNotFound if the key does not exists,
because keyExists seems to not check if a key exists, but if a key is empty.
    @jfrabaute @traefiker
    jfrabaute authored and traefiker committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    720dd9f View commit details
    Browse the repository at this point in the history