Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored logs on windows. #3966

Merged
merged 1 commit into from Oct 2, 2018
Merged

Colored logs on windows. #3966

merged 1 commit into from Oct 2, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 1, 2018

What does this PR do?

Fix colored logs on windows.

Motivation

image 1

image

Additional Notes

Thanks to @AndrewSav

@traefiker traefiker added this to the 1.7 milestone Oct 1, 2018
nmengin
nmengin approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilevauge
emilevauge approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4cb1ae4 into traefik:v1.7 Oct 2, 2018
@ldez ldez deleted the fix/windows-color branch October 2, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@emilevauge emilevauge emilevauge approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/logs kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @emilevauge @nmengin @traefiker