Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent some malformed errors in LE. #4015

Merged
merged 2 commits into from Oct 11, 2018
Merged

Prevent some malformed errors in LE. #4015

merged 2 commits into from Oct 11, 2018

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 10, 2018

What does this PR do?

Prevent some malformed errors.

Motivation

Not being a dominant source of malformed errors in Let's Encrypt logs.

Fixes #4011

More

  • [-] Added/updated tests
  • [-] Added/updated documentation

@traefiker traefiker added this to the 1.7 milestone Oct 10, 2018
nmengin
nmengin reviewed Oct 11, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @ldez .

Very nice PR 😉

WDYT to provide WARN logs with differents messages?
Can be useful to find problem if line/file are not provided by user.

mmatur
mmatur requested changes Oct 11, 2018
View reviewed changes
provider/acme/provider.go Show resolved Hide resolved
juliens
juliens approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1b54f4d into traefik:v1.7 Oct 11, 2018
@traefiker traefiker mentioned this pull request Oct 11, 2018
Closed
@ldez ldez deleted the fix/acme-fqdn branch October 12, 2018 10:50
@ldez ldez changed the title acme: prevent some malformed errors. Prevent some malformed errors in LE. Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @nmengin @traefiker