Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Docker_Acme.md to Readme.md #4025

Merged
merged 1 commit into from Oct 16, 2018
Merged

Rename Docker_Acme.md to Readme.md #4025

merged 1 commit into from Oct 16, 2018

Conversation

vineetvermait
Copy link
Contributor

@vineetvermait vineetvermait commented Oct 11, 2018 •
edited by ldez

What does this PR do?

This should be visible as a part of page load

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the base branch from master to v1.7 October 12, 2018 10:35
@ldez ldez added this to the 1.7 milestone Oct 12, 2018
@ldez ldez added area/acme and removed area/acme labels Oct 12, 2018
@vineetvermait vineetvermait requested review from a team as code owners October 12, 2018 10:37
@ldez ldez modified the milestones: 1.7, next Oct 12, 2018
@ldez ldez changed the base branch from v1.7 to master October 12, 2018 10:37
@ldez ldez removed request for a team October 12, 2018 10:38
@vineetvermait @ldez
Rename Docker_Acme.md to Readme.md
2b3e4b1 
This should be visible as a part of page load
ldez
ldez approved these changes Oct 15, 2018
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 6a55772 into traefik:master Oct 16, 2018
@ldez ldez added area/documentation kind/enhancement a new or improved feature. labels Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/acme area/documentation kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vineetvermait @juliens @mmatur @ldez @traefiker