Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keepTrailingSlash option #4062

Merged
merged 6 commits into from Oct 17, 2018
Merged

Add keepTrailingSlash option #4062

merged 6 commits into from Oct 17, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Oct 17, 2018

What does this PR do?

Add an option to disable the redirection when there is trailing slash in url.

Motivation

Fixes #3782

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

We add the option for compatibility reason.

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

configuration/configuration.go Outdated Show resolved Hide resolved
docs/configuration/commons.md Outdated Show resolved Hide resolved
docs/configuration/commons.md Outdated Show resolved Hide resolved
@ldez ldez removed the bot/no-merge label Oct 17, 2018
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants