Uses ASCII characters to spell Traefik #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traefiker
added
area/acme
area/logs
area/middleware
area/provider/boltdb
area/provider/consul
area/provider/docker
area/provider/etcd
area/provider/ecs
area/provider/eureka
area/provider/k8s/ingress
area/provider/marathon
area/provider/mesos
area/provider/rancher
area/webui
size/L
status/0-needs-triage
labels
mmatur
requested changes
Oct 17, 2018
ldez
added
kind/enhancement
jbdoumenjou
approved these changes
Oct 17, 2018
mmatur
requested changes
Oct 17, 2018
|
@mmatur I don't think this is necessary to update the changelog, but as it has already been modified, I'm OK to keep it. |
|
@geraldcroes Could you please revert the change in the |
traefiker
force-pushed
the
feature/traefik-spelling
branch
from
0824fc9
to
51ce7b1
Compare
|
💔 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does something terrible ... but ... it's probably better that way (at least let us believe that, it'll be easier to accept).
This PR replaces the spelling of our beloved Træfik with Traefik (yes, only plain old boring ascii characters).
Motivation
Oh believe me that there is no desire nor willingness to do so, I'm thinking "Good Bye Old Friend" right now, but it'll be easier to stay consistent in the documentation, comments, toml, code, articles, and so on.
More
Additional Notes
The former æ will stay in the logo (and in our ❤️ )!