Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the note: acme.domains is a startup configuration #4065

Merged
merged 2 commits into from Oct 17, 2018

Conversation

geraldcroes
Copy link
Contributor

@geraldcroes geraldcroes commented Oct 17, 2018

What does this PR do?

Adds the note that acme.domains is a startup configuration only.

Motivation

To make it more obvious for users (cf #4039)

More

  • Added/updated tests
  • Added/updated documentation

docs/configuration/acme.md Outdated Show resolved Hide resolved
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants